containers: some tests always succeed

[montag451]

Since c37e76b machinectl shell is used to run commands inside containers instead of nsenter + su. However machinectl shell does not forward the return code of the command to the caller (see systemd/systemd#4215) so all the tests that use nixos-container run always succeed (e.g container-physical_interfaces.nix). So as long as systemd/systemd#4215 is not solved some tests may succeed when in fact they should have failed.

[montag451]

cc @kampfschlaefer @wlhlm

[kampfschlaefer]

So we need a test to check that the nixos-container tool works as expected?

Wouldn't it be kind of better to revert c37e76b until upstream fixes that?

[wlhlm]

I think switching to systemd-run --wait is the best option here. Also see systemd/systemd#4215 (comment)

[fpletz]

@wlhlm Thanks a lot for the hint! If nobody else wants to take a shot at it I'll try to implement and test this in the next few days.

[Ekleog]

(triage) systemd/systemd#4215 has now been closed without (as far as I understand) the behavior of systemd being changed. Does someone know what was once a reproducer to check whether it's still an issue? I don't personally use machinectl :/

[wlhlm]

The pull request #18825 that first introduced this behavior has been reverted, so this issue shouldn't apply anymore and can be closed.

[montag451]

As suggested by @wlhlm, I will close this issue as it is not relevant anymore