python3Packages: torch-bin and friends should move to autoPatchelfHook and autoAddOpenGLRunpathHook

[ConnorBaker]

Describe the bug

What

The following packages should move to using autoPatchelfHook and autoAddOpenGLRunpathHook:

• nixpkgs/pkgs/development/libraries/science/math/libtorch/bin.nix

  Lines 7 to 8 in c2111b6

  	, addOpenGLRunpath
  	, patchelf

• nixpkgs/pkgs/development/python-modules/torch/bin.nix

  Lines 9 to 12 in c2111b6

  	, addOpenGLRunpath
  	, future
  	, numpy
  	, patchelf

• nixpkgs/pkgs/development/python-modules/torchaudio/bin.nix

  Line 41 in c2111b6

  patchelf --set-rpath "${lib.makeLibraryPath [ stdenv.cc.cc.lib ]}:${torch-bin}/${python.sitePackages}/torch/lib:" \

• nixpkgs/pkgs/development/python-modules/torchvision/bin.nix

  Line 9 in c2111b6

  , patchelf

Why

In addition to autoPatchelfHook being the preferred way to package binaries (https://nixos.wiki/wiki/Packaging/Binaries#Using_AutoPatchelfHook), the autoAddOpenGLRunpathHook should allow us to remove boilerplate phases like:

nixpkgs/pkgs/development/python-modules/torch/bin.nix

Lines 55 to 63 in c2111b6

	postFixup = let
	rpath = lib.makeLibraryPath [ stdenv.cc.cc.lib ];
	in ''
	find $out/${python.sitePackages}/torch/lib -type f \( -name '*.so' -or -name '*.so.*' \) | while read lib; do
	echo "setting rpath for $lib..."
	patchelf --set-rpath "${rpath}:$out/${python.sitePackages}/torch/lib" "$lib"
	addOpenGLRunpath "$lib"
	done
	'';

[nixos-discourse]

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-46/26872/1