Update request: vscode-extensions.ms-dotnettools.csharp: 1.25.x → 2.x

[mausch]

• Package name: vscode extension ms-dotnettools.csharp
• Latest released version: 2.12.4

• Current version on the unstable channel: 1.25.4
• Current version on the stable/release channel: 1.25.4

• Checked the nixpkgs pull requests

Notify maintainers

@jraygauthier

I noticed that ms-dotnettools.csdevkit ( #270423 ) uses ms-dotnettools.csharp 2.x which has replaced OmniSharp with Roslyn... which probably means major changes to the packaging of this extension unfortunately 😞

---

Note for maintainers: Please tag this issue in your PR.

Priorities

Add a 👍 reaction to issues you find important.

[ablearthy]

Works on my machine (note: mktplcRef.arch is required, otherwise by default it downloads extension for arm64):

(pkgs.vscode-utils.buildVscodeMarketplaceExtension {
  mktplcRef = {
    name = "csharp";
    publisher = "ms-dotnettools";
    version = "2.15.30";
    sha256 = "sha256-i5shbpjp0e0qUIG6FLPu1mIN0DD2+zdCq/nZa49v5iI=";
    arch = "linux-x64";
  };

  postPatch = ''
    sed -i -E -e 's_uname -m_${pkgs.coreutils}/bin/uname -m_g' "$PWD/dist/extension.js"
  
    patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" \
      --set-rpath "${lib.makeLibraryPath [ pkgs.stdenv.cc.cc ]}:\$ORIGIN" \
      "./.roslyn/Microsoft.CodeAnalysis.LanguageServer"
  '';
})