Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: changelog targeting contributors #299255

Open
3 tasks done
Aleksanaa opened this issue Mar 26, 2024 · 0 comments
Open
3 tasks done

Documentation: changelog targeting contributors #299255

Aleksanaa opened this issue Mar 26, 2024 · 0 comments

Comments

@Aleksanaa
Copy link
Member

Aleksanaa commented Mar 26, 2024

Problem

People often propose modifications to the package and module structure and contribution guidelines. However, even if such a proposal is adopted, many contributors still won't know about it until some committers keep mentioning changes to them. Some major changes have corresponding RFCs, which is better in this case. Otherwise, we often need to explain it repeatedly.

Here are some historical or ongoing modifications that might fall into this category:

NOTE: This is not a reliable source. This is just a list of things that I remembered. If you want to know the progress of these changes, please search the relevant issues yourself.

  1. Enforcing by-name directory structure for new packages
  2. Manually adding mainProgram in meta field
  3. Discouraging nested and toplevel with, especially meta = with lib; { which was written in nearly every package
  4. Advocating mkDerivation (finalAttrs: { instead of mkDerivation rec {
  5. Using pyproject instead of format in python packaging
  6. Advocating fetchpatch2 instead of fetchpatch (?)
  7. Adding strictDeps = true; where possible (Seems not continued?)

Proposal

  1. After a proposal is fully discussed and consensus is reached, add an explanation about the content of the modification, the reason, possible regression and workarounds, and the planned treatment of existing packages/modules in the changelog. Each piece of content should still be sorted by the time when the PR that modified the changelog was proposed.

  2. Remind all contributors in the PR template that they should check out the changelog regularly.

  3. Adding the changelog should indicate that the modification proposal has been approved. Before this, we should not do treewide modifications to packages/modules, modify the documentation, or request related changes to other people's PRs. However, the process of modifying the basic building functions and documentation can be completed at the same time as the process of modifying the changelog.

Checklist


Add a 👍 reaction to issues you find important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant