Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from outdated vala versions #32800

Closed
Mic92 opened this issue Dec 18, 2017 · 6 comments
Closed

Migrate away from outdated vala versions #32800

Mic92 opened this issue Dec 18, 2017 · 6 comments
Assignees
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 9.needs: clean-up
Projects

Comments

@Mic92
Copy link
Member

Mic92 commented Dec 18, 2017

Issue description

We currently have vala_0_23, vala_0_26, vala_0_26 and vala_0_28 in our repository that are no longer maintained upstream.

The current versions maintained upstream are: 0.34.13, 0.36.8 and 0.38.4

related to #32795

@jtojnar jtojnar added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Dec 18, 2017
@jtojnar jtojnar added this to To Do in GNOME Dec 18, 2017
@Mic92
Copy link
Member Author

Mic92 commented Dec 18, 2017

I talked with upstream and they recommend to set 0.38.4 as default vala version, since it comes with many bugfixes.

UPDATE we already advertise 0.38.x as default.

@jtojnar jtojnar self-assigned this Dec 19, 2017
@jtojnar
Copy link
Contributor

jtojnar commented Dec 19, 2017

I have opened a pull request fixing this.

  • vala_0_23:
    • ccnet
    • finalterm also builds with 0.26, unmaintained there is also a fork but it does not build
    • giv
    • gmpc
    • libappindicator
    • libindicate
    • libosinfo
    • libunity also builds with 0.26, hideously outdated
    • midori also builds with 0.34
    • seafile-shared
    • synapse also builds with 0.34
  • vala_0_26:
    • vanubi also builds with 0.28
  • vala_0_28:
    • shotwell
    • valum
  • vala_0_34:
    • deepin-terminal
    • gencfsm
    • libskk

So now we have

  • vala_0_26:
    • finalterm
    • libunity
  • vala_0_28:
    • vanubi
  • vala_0_34:
    • midori
    • synapse

allowing us to drop vala_0_23.

If we want to get rid of more, we can move all of them to vala_0_26.

@jtojnar jtojnar mentioned this issue Dec 19, 2017
8 tasks
@Mic92
Copy link
Member Author

Mic92 commented Dec 19, 2017

Is libunitystill a thing? Did not ubuntu dropped unity development?

@jtojnar
Copy link
Contributor

jtojnar commented Dec 19, 2017

I do not know, the last update was in 2012 and it does not seem to be used anywhere in nixpkgs, it is probably okay to drop it.

@Mic92
Copy link
Member Author

Mic92 commented Dec 19, 2017

I would say it is safe to do so.

GNOME automation moved this from To Do to Done Dec 20, 2017
@jtojnar
Copy link
Contributor

jtojnar commented Dec 20, 2017

Actually, why not just change finalterm and vanubi to vala_0_38 and mark them with meta.broken = true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 9.needs: clean-up
Projects
GNOME
  
Done
Development

No branches or pull requests

2 participants