Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help welcome (but not required) for finishing LibreOffice 6.0 update or improving LO package #36111

Closed
7c6f434c opened this issue Feb 28, 2018 · 7 comments

Comments

@7c6f434c
Copy link
Member

We need a new LibreOffice Fresh before 18.03.

I have a good chance of doing it in time, but in case anyone wants to speed the things up without re-doing all that I have done…

I think I can already make it build, but the tests fail. Rebuilds take a lot of background time, and I am not ready to commit foreground (human) time to doing detailed nix-shell debugging right now.

The current problem is that the LibreOffice test suite complains about no fonts being available despite FONTCONFIG_FILE being set. I haven't finished building with Liberation fonts added to the font configuration yet.

If someone wants to suggest some changes or try to take over, my current state is in the branch https://github.com/7c6f434c/nixpkgs/tree/libreoffice-6

The source list generator fixes are already in master because they are purely additive.

I will likely fix the issues myself… eventually, but help appreciated.

Also, if someone wants to propose any changes like a fix for the .desktop files, now is a good time.

@7c6f434c
Copy link
Member Author

Update: made sure that Calibri maps to the metrically compatible Carlito, as LibreOffice expects.

@7c6f434c
Copy link
Member Author

Update:

  • good: added required fonts, new rendering test failures stopped coming up — see makeFontsConf and extra include directories #36116 for a discussion of a better long-term solution
  • bad: a test failure SwUiWriterTest::testTdf115013 seems to be failing in a correctness-related way, which I don't like and I am not sure if it is a good idea to comment out this test (unlike rendering).

@7c6f434c
Copy link
Member Author

@7c6f434c
Copy link
Member Author

7c6f434c commented Mar 1, 2018

Update: if I disable this test, everything builds fine, and launching LibreOffice/creating a spreadhseet works. Sigh.

@7c6f434c
Copy link
Member Author

7c6f434c commented Mar 1, 2018

Update: even though adding the fonts seems to solve some of the problems with tests, there are still tests that fail on rendering, so I will not try to clean up the excluded-tests list. Does anyone want to pick this up?

@7c6f434c
Copy link
Member Author

7c6f434c commented Mar 1, 2018

Update: squashed the commits, will probably merge as-is unless some feedback happens today. «Please wait, I will comment next week» does count as feedback.

@7c6f434c
Copy link
Member Author

7c6f434c commented Mar 1, 2018

Gave up and pushed. 6.0.2 is already out. Sigh.

@7c6f434c 7c6f434c closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant