Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git credential-osxkeychain does not appear to work [ darwin ] #36223

Closed
ghost opened this issue Mar 2, 2018 · 8 comments
Closed

git credential-osxkeychain does not appear to work [ darwin ] #36223

ghost opened this issue Mar 2, 2018 · 8 comments
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin

Comments

@ghost
Copy link

ghost commented Mar 2, 2018

Issue description

I installed git via nix-env -iA latest.gitAndTools.gitFull.
Everything installed fine, but my SSH credentials are not being cached correctly.
This appears to be a problem with git credential-osxkeychain.
Running git credential-osxkeychain erase hangs indefinitely. Any of the git credential-osxkeychain commands seem to hang too.
Using Apple's version of git available by xcode-select --install works as expected:

 git --version                 
git version 2.14.3 (Apple Git-98)

Steps to reproduce

  1. nix-env -iA latest.gitAndTools.gitFull
  2. clone a private repo that requires your SSH key
  3. enter the passphrase
  4. clone another private repo and notice you still need to enter they passphrase

Technical details

Note that latest is a channel I added with nix-channel --add https://github.com/NixOS/nixpkgs/archive/master.tar.gz latest

 nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-darwin"`
 - host os: `Darwin 17.4.0, macOS 10.13.3`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.0`
 - channels(root): `"nixpkgs-18.03pre129212.098c7f3d945"`
 - channels(efx): `"nixpkgs-latest, latest"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`
@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Mar 6, 2018
@LnL7
Copy link
Member

LnL7 commented Mar 6, 2018

I think we generally try to avoid macOS specific features like that since it usually depends on impure parts of the system like frameworks.

@ghost
Copy link
Author

ghost commented Mar 7, 2018

This makes sense to me. Shouldn't we disable installing this when macOS users install git using nix though? That way we avoid confusion that it should work.

@LnL7
Copy link
Member

LnL7 commented Mar 7, 2018

Yeah that's a good idea.

@matthewbauer
Copy link
Member

I cannot reproduce this. One thing that should happen when first doing this is that the dialog opens asking if the app can access your keychain. Perhaps this is not happening? Some AV or enterprise config profilsmes might disable this feature for unknown binaries.

@ghost
Copy link
Author

ghost commented Mar 29, 2018

interesting @matthewbauer . I had first installed git using xcode-select, so I wonder if that could impact this. Also, our organization uses Jamf for device profile management. I'm not sure how to determine if that impacts this.

@stale
Copy link

stale bot commented Jun 4, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2020
@uri-canva
Copy link
Contributor

uri-canva commented Aug 7, 2020

Related: #15686, #62353.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 7, 2020
@stale
Copy link

stale bot commented Feb 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 3, 2021
@ghost ghost closed this as completed Apr 22, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

No branches or pull requests

3 participants