Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB redirect broken in virt-viewer #36533

Closed
d4g opened this issue Mar 8, 2018 · 6 comments
Closed

USB redirect broken in virt-viewer #36533

d4g opened this issue Mar 8, 2018 · 6 comments

Comments

@d4g
Copy link
Contributor

d4g commented Mar 8, 2018

Issue description

USB redirect is brokoen in virt-viewer.
selection_016

Listing of directory shows the issue:
/nix/store/rlkv757g7fmz05qfh1xpdg44zg2v2qfv-spice-gtk-0.34/bin/spice-client-glib-usb-acl-helper -> /run/wrappers/bin/spice-client-glib-usb-acl-helper /nix/store/rlkv757g7fmz05qfh1xpdg44zg2v2qfv-spice-gtk-0.34/bin/spice-client-glib-usb-acl-helper.real
The symlink shows to itself instead of spice-client-glib-usb-acl-helper.real

Steps to reproduce

  • Open virt-viewer
  • Connect to qemu/kvm/libvirt
  • Try to redirect USB
  • Read the error message

Technical details

NixOS details

  • system: "x86_64-linux"
  • host os: Linux 4.15.7, NixOS, 18.03pre130932.cc4677c36ee (Impala)
  • multi-user?: yes
  • sandbox: no
  • version: nix-env (Nix) 2.0
  • channels(root): "nixos-18.03pre130932.cc4677c36ee"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs
  • nix-channel: https://nixos.org/channels/nixos-unstable

Device details

  • device: 20J6S0DM00 ThinkPad T470p
  • cpu: Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
  • gpu: Intel Corporation Device 591b (rev 04)
@d4g
Copy link
Contributor Author

d4g commented Mar 8, 2018

@fpletz

@xeji
Copy link
Contributor

xeji commented Mar 9, 2018

USB redirect requires a setuid wrapper (which cannot be included in the package), see #35214 .
Please activate this in configuration.nix as shown here: #35214 (review) and test again.

@xeji
Copy link
Contributor

xeji commented Mar 9, 2018

Anyway, this should fail with an appropriate message if the setuid wrapper doesn't exist.
@Mic92 has also suggested putting this into a nixos module.

@d4g
Copy link
Contributor Author

d4g commented Mar 15, 2018

It should not require a setuid wrapper, if the user is in the appropriate group and has read/write access to the devices.

If you read the error description, there is a problem with the symlink.
This was working on former versions of the package @xeji

@xeji
Copy link
Contributor

xeji commented Mar 15, 2018

I will look into it and fix the broken symlink.

@xeji
Copy link
Contributor

xeji commented Mar 16, 2018

Fixed in #37184. If you do not wish to use polkit authentication and the setuid wrapper, you can now build the package with withPolkit = false; and use custom udev rules instead. See comments in code of #37184.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants