Refactor Eclipse

[Andrei-Pozolotin]

1. Guys (people contributed to editors/eclipse in the past):
   @rycee rycee
   @edolstra edolstra
   @bjornfor bjornfor
   @MarcWeber MarcWeber
   @vcunat vcunat
   @jerith666 jerith666
   @goetzst goetzst
   @muradu muradu
   @svenkeidel svenkeidel
   @Phreedom Phreedom
   @qknight qknight
   @ecarreras ecarreras
   @zraexy zraexy
   @volth volth
   @tobias-hammerschmidt tobias-hammerschmidt
   @rbvermaa rbvermaa
   @pSub pSub
   @MoritzMaxeiner MoritzMaxeiner
   @bluescreen303 bluescreen303
   @gounnoticed gounnoticed
   @jtojnar jtojnar
   @earldouglas earldouglas
   @i-bot i-bot
   @dguibert dguibert
   @DamienCassou DamienCassou
   @coreyoconnor coreyoconnor
   @chris-martin chris-martin
   @aske aske

2. Please consider refactoring editors/eclipse:
   https://github.com/NixOS/nixpkgs/tree/master/pkgs/applications/editors/eclipse

3. Motivation: missing features:

• runtime, dropin, product
• clean package name space
• modular package structure
• mirrors eclipse update sites
• supports nixpkgs overlays
• supports dropin dependency
• supports product inheritance
• automatically downloads oracle-jdk
• provisions eclipse default settings
• supports desktop item customization
• provides splash screen customization
• supports launching companion jdks/jres
• exposes installed applications for review
• enables many platform / version combinations

4. A prototype which provides missing features:
   https://github.com/random-nixor/nixpkgs-eclipse

[bjornfor]

I think if you already have a prototype, the best way forward is to submit a PR.

[Andrei-Pozolotin]

@bjornfor re: submit a PR - my nix experience is 1 week long. my prototype is in private-repo format. I am looking for nix expert(s) who can help convert the prototype into public-repo format and apply all other corrections I am sure will be needed and that I am not even aware of.

[PierreR]

Just in case, I have this use case: #39015 I believe it is not covered by the current implementation.

[jerith666]

Sorry for the radio silence here. I am interested in these kinds of high-level improvements to the eclipse expressions in nixpkgs, but I have to admit that i haven't had the time to grok your approach yet.

Is there a way you can move the existing eclipse expressions in this direction incrementally? Those kinds of changes are easier to build PRs around, easier for reviewers to digest, etc.

Thanks for contributing these ideas in any case! :)

[Andrei-Pozolotin]

@jerith666 Matt:

1. re: haven't had the time to grok - please take you time
2. re: move in this direction incrementally - I do not think so
3. I've used https://github.com/random-nixor/nixpkgs-eclipse for 3 months,
   and I am happy so far:

• managed to adapt it to many complex eclipse setups,
• new layout seems feature complete
• needs final cleanup and review

[stale]

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
2. Ask on the NixOS Discourse.
3. Ask on the #nixos channel on irc.freenode.net.