Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nixpkgs defaultLocale is not set by NixOS defaultLocale. #39610

Open
nbp opened this issue Apr 27, 2018 · 3 comments
Open

Nixpkgs defaultLocale is not set by NixOS defaultLocale. #39610

nbp opened this issue Apr 27, 2018 · 3 comments
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

Comments

@nbp
Copy link
Member

nbp commented Apr 27, 2018

Forwarding issue from: https://mamot.fr/@yom/99932015049044453

Issue description

The problem is that NixOS configuration i18n.defaultLocale is not being transfered to Nixpkgs config. Therefore installing firefox-bin package as part of the default set of packages would select en_US instead of the one corresponding to the default locale.

Steps to reproduce

Add NixOS option i18n.defaultLocale to "fr_FR.UTF-8".
Add pkgs.firefox-bin as part of the environment.systemPackages.
$ nixos-rebuild switch
$ firefox
--> Firefox should be in French.

Technical details

We should probably add something like the following and ensure that the defaultLocale is processed properly as part of the minimal set of packages needed to evaluate the pkgs argument.

{config, ...}:

{ nixpkgs.config = {
    i18n.defaultLocale = config.i18n.defaultLocale;
  };
}
@matthewbauer
Copy link
Member

So I didn't even realize that config.i18n.defaultLocale existed. Is there any documentation for it? I'm interested in standardizing these configs in Nixpkgs (#39580). In some ways it overlaps with the NixOS module system.

@FlorentBecker
Copy link
Contributor

This seems to be because the firefox package does not come with any language packs.

@stale
Copy link

stale bot commented Jun 4, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Development

No branches or pull requests

3 participants