Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/acme: allowKeysForGroup has no effect after cert is already created #48845

Closed
arianvp opened this issue Oct 22, 2018 · 6 comments · Fixed by #72056
Closed

nixos/acme: allowKeysForGroup has no effect after cert is already created #48845

arianvp opened this issue Oct 22, 2018 · 6 comments · Fixed by #72056

Comments

@arianvp
Copy link
Member

arianvp commented Oct 22, 2018

Issue description

  1. Changing group or user will not do anything till the next round of refresh
  2. Even after refresh, changes to allowKeysForGroup do not actually propagate. The permissions of the key are not changed. Only of the surrounding directory.

Steps to reproduce

  1. Create a cert with
    security.acme.certs.<name>.group = "hello";
  2. Now change to : security.acme.certs.<name>.group = "world";
  3. Afterwards add security.acme.certs.<name>.allowKeysForGroup =true;
  4. Observe that the owner is still hello and that there are no group read permissions yet
  5. Even after manually refreshing by calling the timer manually, the group did change, by the permission bits still not allow read access to group even if allowKeysForGroup is set

Technical details

Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.

@arianvp arianvp changed the title nixos/acme: permissions do not change until refresh nixos/acme: allowKeysForGroup has no effect after cert is already created Oct 22, 2018
@infinisil
Copy link
Member

Hey I made a PR that fixes this, would love to have somebody else make sure it fixes this problem: #72056

@arianvp
Copy link
Member Author

arianvp commented Apr 16, 2020

Lets re-open this issue.

@infinisil infinisil reopened this Apr 16, 2020
@stale
Copy link

stale bot commented Oct 13, 2020

Hello, I'm a bot and I thank you in the name of the community for opening this issue.

To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it.

If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use Git blame or GitHub's web interface on the relevant files to find them.

Lastly, you can always ask for help at our Discourse Forum or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 13, 2020
@arianvp
Copy link
Member Author

arianvp commented Oct 13, 2020

wasnt this fixed by the recent bugfix round @m1cr0man ?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 13, 2020
@m1cr0man
Copy link
Contributor

Yeah, that option has been removed Infact :P

@m1cr0man
Copy link
Contributor

m1cr0man commented May 4, 2021

This option is now gone in favour of always making the certificates group readable and owned by the acme user, and letting users change only the group that will be applied to them. Closing this issue.

@m1cr0man m1cr0man closed this as completed May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants