Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-generate-config can write incorrect unionfs #50848

Open
cyounkins opened this issue Nov 20, 2018 · 1 comment
Open

nixos-generate-config can write incorrect unionfs #50848

cyounkins opened this issue Nov 20, 2018 · 1 comment
Labels
0.kind: bug 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos

Comments

@cyounkins
Copy link
Contributor

Issue description

As of NixOS 18.09 nixos-generate-config can write an incorrect unionfs mount when used on the livecd without --root /mnt

  fileSystems."/nix/store" =
    { device = "unionfs";
      fsType = "fuse.unionfs";
    };

Here is the whole thing: https://gist.github.com/cyounkins/7b56d15576935cda5102be46edf43c4f

Steps to reproduce

  1. Boot the livecd
  2. nixos-generate-config
  3. Observe the written hardware configuration

It should be incorrect to specify device = "unionfs" without union directories. Maybe we could also warn if we think the invocation is incorrect.

Some authors of the script: @edolstra @wizeman

@stale
Copy link

stale bot commented Jun 3, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos
Projects
None yet
Development

No branches or pull requests

2 participants