Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql: backport parallel-make on macOS? #51251

Closed
endgame opened this issue Nov 29, 2018 · 6 comments
Closed

postgresql: backport parallel-make on macOS? #51251

endgame opened this issue Nov 29, 2018 · 6 comments

Comments

@endgame
Copy link
Contributor

endgame commented Nov 29, 2018

Issue description

Continues #51093. Parallel builds of postgresql have been disabled on darwin as a blunt fix. A patch was recently posted to the pgsql-bugs mailing list to fix this: https://git.postgresql.org/gitweb/?p=postgresql.git;a=patch;h=826eff57c4c23f77314ba7151d3dc506ce0fa24c

We may want to integrate this patch into nixpkgs, as the next upstream release is scheduled for February. I won't have time to do this, I'm afraid.

Ping @delroth , who can decide whether this is a worthwhile thing to backport, and close if not.

@delroth
Copy link
Contributor

delroth commented Nov 29, 2018

I think I'd rather see ranlib fixed as we talked about in #51221, if we can make it work.

@endgame
Copy link
Contributor Author

endgame commented Nov 29, 2018

Cool. I'll leave this for you to close, then, once you decide whether the ranlib patches are going to work?

@thoughtpolice
Copy link
Member

Yes, this should be done in ranlib if possible and it can be fixed for all our Darwin builds. It seems like Postgres might not be the first or last to suffer from this.

@matthewbauer
Copy link
Member

I would not count on the fix being backported to 18.09. It depends on what we end up agreeing on. We may have to expose utimensat which is only available on macOS 10.13, breaking support for previous versions. That should probably just go to unstable. Just disabling parallel building in the latest release sounds like the safest idea to me.

@endgame
Copy link
Contributor Author

endgame commented Nov 30, 2018

@matthewbauer This bug isn't about backporting the ranlib fix to 18.09, but about backporting a build-system fix the postgres devs have proposed (the target for the .a file that the build races over gets an extra touch $@, which supports subsecond timestamps).

@endgame
Copy link
Contributor Author

endgame commented Dec 3, 2018

The answer the question asked by this issue is "no", as that the patch to turn off subsecond timestamps on Darwin builds of gnumake just landed (#51408).

@endgame endgame closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants