Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong license tag for pyaxmlparser #54338

Closed
armijnhemel opened this issue Jan 19, 2019 · 5 comments
Closed

Wrong license tag for pyaxmlparser #54338

armijnhemel opened this issue Jan 19, 2019 · 5 comments

Comments

@armijnhemel
Copy link
Contributor

This license is incorrect. The license in the upstream project is not correct, as there are files copied from Androguard that have the Apache 2 license:

https://github.com/appknox/pyaxmlparser/blob/master/pyaxmlparser/axmlparser.py

@dotlambda
Copy link
Member

cc maintainer @Ma27

@Ma27
Copy link
Member

Ma27 commented Jan 20, 2019

I originally looked at https://github.com/appknox/pyaxmlparser/blob/master/LICENSE and https://pypi.org/project/pyaxmlparser/

I didn't know about the issue with the sourcefiles, but as the entire package is published as MIT, can we somehow pass both licenses to meta.licenses?

@dotlambda
Copy link
Member

can we somehow pass both licenses to meta.licenses?

That's what I did in 4e0f079.

@Ma27
Copy link
Member

Ma27 commented Jan 20, 2019

nvmd then, I just looked at the diff in the original comment, sorry!

@armijnhemel
Copy link
Contributor Author

I originally looked at https://github.com/appknox/pyaxmlparser/blob/master/LICENSE and https://pypi.org/project/pyaxmlparser/

I didn't know about the issue with the sourcefiles, but as the entire package is published as MIT, can we somehow pass both licenses to meta.licenses?

The upstream project didn't correctly identify the licenses used, so I filed an issue there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants