Stripping in stdenv should not ignore errors

[edolstra]

Ignoring errors is a source of non-determinism. E.g. if the disk is full:

strip:/nix/store/8zwj00xk91rl30g532pq00xvvnkvm58d-opencollada-1.3-18da7f4109a8eafaa290a33f5550501cc4c8bae8/lib/opencollada/steBji1n: No space left on device
strip: cannot create tempdir for archive copying (error: No space left on device)

after which the build succeeds, but with a different result than if the disk had not been full.

[zimbatm]

I guess the issue here is that it would also add a lot of work for the packager to specify which programs should be strippable or not right ? I'm not even sure if we have a framework to list all the executables and libraries that a package is supposed to produce.

Stopping to ignore failures on strip is just a matter of removing || true at the end of that line:

nixpkgs/pkgs/build-support/setup-hooks/strip.sh

Line 33 in 2def8e7

find $dirs -type f -print0 | xargs -0 ${xargsFlags:--r} strip $commonStripFlags $stripFlags || true

[Profpatsch]

triage: it looks like this hasn’t been fixed yet?

[stale]

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
2. Ask on the NixOS Discourse.
3. Ask on the #nixos channel on irc.freenode.net.