Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncthing is outdated #57170

Closed
jabranham opened this issue Mar 9, 2019 · 1 comment
Closed

Syncthing is outdated #57170

jabranham opened this issue Mar 9, 2019 · 1 comment

Comments

@jabranham
Copy link
Contributor

Issue description

Syncthing 1.1.0 is out, but applying this:

diff --git a/pkgs/applications/networking/syncthing/default.nix b/pkgs/applications/networking/syncthing/default.nix
index a2e38577ecd..1bc83170a66 100644
--- a/pkgs/applications/networking/syncthing/default.nix
+++ b/pkgs/applications/networking/syncthing/default.nix
@@ -3,14 +3,14 @@
 let
   common = { stname, target, postInstall ? "" }:
     buildGoPackage rec {
-      version = "1.0.1";
+      version = "1.1.0";
       name = "${stname}-${version}";
 
       src = fetchFromGitHub {
         owner  = "syncthing";
         repo   = "syncthing";
         rev    = "v${version}";
-        sha256 = "09qrdh6rvphh6sjyzh3jjil1fkrp9jp8mzrbz9ncqhvqra70f6sw";
+        sha256 = "1qmrh3c4p5vxzjqd0zdmvcqffq75gl4qfg0s8qpkgvdc7qrzzi7i";
       };
 
       goPackagePath = "github.com/syncthing/syncthing";

results in lots of output like:

lib/pmp/pmp.go:15:2: cannot find package "github.com/AudriusButkevicius/go-nat-pmp" in any of:
        /nix/store/m6g3bwrh2g44ayjq9hsgzwlabp1gqzgq-go-1.11.5/share/go/src/github.com/AudriusButkevicius/go-nat-pmp (from $GOROOT)
        /build/go/src/github.com/AudriusButkevicius/go-nat-pmp (from $GOPATH)
lib/protocol/protocol.go:16:2: cannot find package "github.com/bkaradzic/go-lz4" in any of:
        /nix/store/m6g3bwrh2g44ayjq9hsgzwlabp1gqzgq-go-1.11.5/share/go/src/github.com/bkaradzic/go-lz4 (from $GOROOT)
        /build/go/src/github.com/bkaradzic/go-lz4 (from $GOPATH)

did something change in the go packaging process?

@marsam marsam mentioned this issue Mar 11, 2019
10 tasks
@marsam
Copy link
Contributor

marsam commented Mar 11, 2019

did something change in the go packaging process?

it was missing the goDeps attribute; because syncthing doesn't vendor its dependencies anymore, and uses go modules instead syncthing/syncthing#5384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants