Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patchShebangs does not support multiple arguments #57695

Closed
jtojnar opened this issue Mar 15, 2019 · 0 comments
Closed

patchShebangs does not support multiple arguments #57695

jtojnar opened this issue Mar 15, 2019 · 0 comments
Labels
0.kind: enhancement 3.skill: good-first-bug 6.topic: developer experience
Milestone
19.09

Comments

@jtojnar
Copy link
Contributor

jtojnar commented Mar 15, 2019

I have been burned by this several times; and I am not alone: #57027 (comment).

When calling patchShebangs with multiple arguments, we should either patch all of them or print an error. Ignoring arguments silently should be a crime.

cc @hedning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: enhancement 3.skill: good-first-bug 6.topic: developer experience
Projects
None yet
Milestone
19.09
Development

No branches or pull requests
2 participants
@matthewbauer @jtojnar