Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setAttrByPath should take a set as an argument #58133

Open
Shou opened this issue Mar 22, 2019 · 1 comment
Open

setAttrByPath should take a set as an argument #58133

Shou opened this issue Mar 22, 2019 · 1 comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

Comments

@Shou
Copy link
Contributor

Shou commented Mar 22, 2019

Issue description

setAttrByPath currently takes two arguments, the key and the value, and returns a new set where the given key is set to the given value. While setAttr takes a set, key, and value, but does not allow for full paths like implied by the name of the function at hand. I think it would fit better into the attrsets module by taking a set as an argument as well so setAttrByPath : Set -> [String] -> a -> Set. setAttr can then be defined in terms of setAttrByPath, and we can also add a new function that covers the old behaviour, also defined in terms of setAttrByPath.

@stale
Copy link

stale bot commented Jun 3, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Development

No branches or pull requests

1 participant