Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patchbay (secure scuttlebutt) #59100

Closed
thedavidmeister opened this issue Apr 7, 2019 · 15 comments
Closed

add patchbay (secure scuttlebutt) #59100

thedavidmeister opened this issue Apr 7, 2019 · 15 comments

Comments

@thedavidmeister
Copy link
Contributor

thedavidmeister commented Apr 7, 2019

Issue description

i'd like to use secure scuttlebutt client patchbay and/or patchwork

Steps to reproduce

Technical details

Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.

@bricewge
Copy link
Contributor

bricewge commented Apr 7, 2019

If v2 is enough for you patchwork-classic is already available since #42151.

Their is also a previous PR #53156 to add them both.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 30.0 DAI (30.0 USD @ $1.0/DAI) attached to it.

@thedavidmeister
Copy link
Contributor Author

cool, also cross linking https://github.com/NixOS/nixpkgs/pull/59111/files

@thedavidmeister
Copy link
Contributor Author

combining #59111 (fixes gtk issues that cause image uploads to crash) and the older #53156 that also includes patchbay is probably the right approach

plus the cleanup comments in #59111

@thedavidmeister
Copy link
Contributor Author

@bricewge i do find it a bit odd that you're claiming 100% of a bounty for minor/optional cleanup of existing PRs

not sure what ettiquite applies with @gitcoinbot and @livnev ?

@livnev
Copy link
Contributor

livnev commented Apr 15, 2019

@thedavidmeister @bricewge I'm not sure if gitcoin supports splitting bounties, but if another contributor wants to step up I can just make a new bounty for one of the other related issues and approve them for it.

@thedavidmeister
Copy link
Contributor Author

thedavidmeister commented Apr 20, 2019

@livnev i'm still working on it and planning to land the PR i put up soonish

i do appreciate the review and tweaks from @bricewge but i also think the PR is essentially mergeable in it's current state 🤷‍♂️

@livnev
Copy link
Contributor

livnev commented Apr 20, 2019

@thedavidmeister I've changed this into a "cooperative" bounty. Now you should also be able to claim it.

@thedavidmeister
Copy link
Contributor Author

ooooh! cool @livnev

i have zero experience with gitcoin so let's see what happens...

i'll do some cleanup of that branch now

@thedavidmeister thedavidmeister mentioned this issue May 2, 2019
10 tasks
@gitcoinbot
Copy link

💰 A crowdfund contribution worth 30.00000 DAI (30.0 USD @ $1.0/DAI) has been attached to this funded issue from @.💰

Want to chip in also? Add your own contribution here.

@gitcoinbot
Copy link

gitcoinbot commented May 4, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 month from now.
Please review their action plans below:

1) thedavidmeister has started work.

  1. Put up PR
  2. Test locally (NixOS)
  3. Respond to and resolve community feedback
  4. Merge PR
  5. Minimal working patchwork 3.11.4 AppImage on linux is current target (mac requires complex node2nix implementation)

Learn more on the Gitcoin Issue Details page.

@livnev
Copy link
Contributor

livnev commented May 22, 2019

@thedavidmeister Let's hope the PR gets merged into master soon. It's working well for me.

@infinisil
Copy link
Member

#61530 is merged :)

@gitcoinbot
Copy link

Cypherpunk Mind ⚡️ A *Cypherpunk Mind* Kudos has been sent to @thedavidmeister for this issue from @. ⚡️

Nice work @thedavidmeister!
Your Kudos has automatically been sent in the ETH address we have on file.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 30.0 DAI (30.0 USD @ $1.0/DAI) (plus a crowdfund of 30.0 DAI worth 30.0 USD) attached to this issue has been approved & issued to @thedavidmeister.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants