Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildinput inconsistent treating of nested lists #60442

Open
alexarice opened this issue Apr 29, 2019 · 4 comments
Open

buildinput inconsistent treating of nested lists #60442

alexarice opened this issue Apr 29, 2019 · 4 comments
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

Comments

@alexarice
Copy link
Contributor

Issue description

If buildInputs is given a list that contains list e.g.
buildInputs = [ [a] b c ]
it sometimes successfully passes in the inputs and sometimes doesn't
i have seen this occur in cases such as
buildInputs = [ a b ] ++ lib.optional buildDocs [ builddocdep ]
(although this is probably incorrect I expect it may happen a couple of times in nixpkgs)

Steps to reproduce

  • clone nixpkgs repository
  • run nix-build -A grim
  • It builds
  • go into the repository and change buildInputs in grim to
  buildInputs = [
    [cairo]
    libjpeg
    wayland
    wayland-protocols
  ];
  buildInputs = [
    cairo
    libjpeg
    [wayland]
    wayland-protocols
  ];

Technical details

  • system: "x86_64-linux"
  • host os: Linux 4.19.36, NixOS, 19.09pre177249.dfd8f84aef1 (Loris)
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.2.2
  • channels(alex): ""
  • channels(root): "nixos-19.09pre177249.dfd8f84aef1"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos
@alexarice
Copy link
Contributor Author

Feel it is worth adding that grim does not build without the wayland buildInput

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@alexarice
Copy link
Contributor Author

I believe this is still relevant though I haven't investigated in ages

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2020
@stale
Copy link

stale bot commented Nov 30, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Development

No branches or pull requests

1 participant