Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor r-modules / rPackages / etc - hard to override #60493

Open
deliciouslytyped opened this issue Apr 30, 2019 · 1 comment
Open

Refactor r-modules / rPackages / etc - hard to override #60493

deliciouslytyped opened this issue Apr 30, 2019 · 1 comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

Comments

@deliciouslytyped
Copy link
Contributor

deliciouslytyped commented Apr 30, 2019

Sorry if I missed something;
Either the R packages implementation needs more documentation or it needs to be refactored. It seems utterly impossible to override most things.

I was trying to help someone to debug reticle and I would have wanted to recompile with lower optimization levels and/or various changed compilation flags. The current infrastructure does not visibly support this.

Note:
My mostly unsuccessful research suggests that R CMD INSTALL may rely on --configure-vars, --configure-flags, and some kind of "makevars" file, for influencing package compilation.
Out of these, --configure-flags is used at

$rCommand CMD INSTALL $installFlags --configure-args="$configureFlags" -l $out/library .
but I could not see a way to actually override that because everything is called in an opaque way from...IIRC whatever provides rWrapper.

I managed to hack in some stuff by overriding preConfigure on the stdenv passed in to the infrastructure :P , but I was ultimately unsuccessful. Maybe the optimization flags were coming from GCC? - my extra flags did not seem to appear regardless.

TL;DR: confusion and opacity.

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Development

No branches or pull requests

1 participant