Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services.xserver.videoDrivers allows arbitrary value #62860

Open
chrissound opened this issue Jun 8, 2019 · 2 comments
Open

services.xserver.videoDrivers allows arbitrary value #62860

chrissound opened this issue Jun 8, 2019 · 2 comments
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos

Comments

@chrissound
Copy link

Issue description

  services.xserver = {
    #videoDrivers = [ "nvidia" ];
    videoDrivers = [ "aoeueoeuo8euoarue8euoa8" ];

The above would 'work' fine - a nixos-rebuild switch reports no errors, when really it should report an error?

@Ma27
Copy link
Member

Ma27 commented Jun 8, 2019

The current type declaration in the module says types.attrs types.str, so indeed any string can be specified as video driver.

However this might be confusion, but isn't actually a problem as each string is filtered out by the attrByPath expression while generating the X11 config.

I'm not sure if I'm missing anything, but actually it should be possible to replace the else null by a throw to ensure that evaluation breaks if an invalid driver is specified.

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos
Projects
None yet
Development

No branches or pull requests

3 participants