Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: handle circular test dependencies #63168

Open
FRidh opened this issue Jun 15, 2019 · 5 comments
Open

Python: handle circular test dependencies #63168

FRidh opened this issue Jun 15, 2019 · 5 comments
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python

Comments

@FRidh
Copy link
Member

FRidh commented Jun 15, 2019

Issue description

It's not uncommon for test tools to depend on each other in each others checkInputs.

Steps to reproduce

Technical details

Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.

@jonringer
Copy link
Contributor

@FRidh bump

I've seen the otherpackage.overrideAttrs(oldAttrs: { doCheck = false; }); hack, but is there another solution to this?

@FRidh
Copy link
Member Author

FRidh commented Oct 20, 2019

Nope. Nix creates a directed acyclic graph so it is fundamentally impossible to solve this correctly aside from breaking these loops in such a way. Ideally we would have an automated way to break the loop and then rebuild the package with tests again.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@jonringer
Copy link
Contributor

@FRidh unless we have a way to recursively disable tests for an entire dependency tree, I don't see this issue going anywhere. The current paradigm of disabling testing on the few packages when it's applicable (hypothesis, pytest, very few others) is okay with me for the time being. If this does become a broader issue, then it might be worth revisiting.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@stale
Copy link

stale bot commented Nov 30, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python
Projects
None yet
Development

No branches or pull requests

2 participants