Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dontUse$framework$phase to buildRustPackage and friends #66148

Open
worldofpeace opened this issue Aug 6, 2019 · 6 comments
Open

Add dontUse$framework$phase to buildRustPackage and friends #66148

worldofpeace opened this issue Aug 6, 2019 · 6 comments
Labels
0.kind: bug 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

Comments

@worldofpeace
Copy link
Contributor

Describe the bug
I feel like this is already a pretty established ui for some setup hooks and would be intuitive if used for buildRustPackage etc. and was documented.

Should have the same effects as nulling the phases.

Additional context
Asking people to do this so we can use the phases from meson or just stdenv
and thinking it would be nice if pretty much every build$FrameworkPackage had this.

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute: rustPlatform.buildRustPackage etc.
@worldofpeace
Copy link
Contributor Author

cc @Mic92

any idea how I could add this to buildRustPackage?

@Mic92
Copy link
Member

Mic92 commented Aug 7, 2019

So you mean, we would have a package that when added to buildInputs would pull in rust-related build hooks?

@worldofpeace
Copy link
Contributor Author

So you mean, we would have a package that when added to buildInputs would pull in rust-related build hooks?

Um not sure about that.

I was thinking at least having them as parameters to buildRustPackage?

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@Mic92
Copy link
Member

Mic92 commented Jun 2, 2020

Things like dontBuild dontUnpack should work with buildRustPackage. Not sure what is missing.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@stale
Copy link

stale bot commented Nov 29, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Development

No branches or pull requests

2 participants