Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create vscodium-with-extensions #70624

Open
turion opened this issue Oct 7, 2019 · 7 comments
Open

Create vscodium-with-extensions #70624

turion opened this issue Oct 7, 2019 · 7 comments

Comments

@turion
Copy link
Contributor

turion commented Oct 7, 2019

Since #59028 there is the package vscodium. It accepts basically the same extensions as vscode, as far as I understand. It would be cool if there was vscodium-with-extensions that works the same as vscode-with-extensions. Ideally, a lot of code would be shared between these two functions, but I'm not sure how to do that. If you can provide some advice, I'm willing to try implementing it.

@eadwu @volth @matthewbauer @angristan

@eadwu
Copy link
Member

eadwu commented Oct 8, 2019

From what I remember, vscode-with-extensions is just a wrapper script to set the extension directory to the derivation that contains the extensions so this shouldn't be that hard.

@raboof
Copy link
Member

raboof commented Jan 3, 2020

Yes, in fact you can already plug vscodium into vscode-with-extensions - I created https://nixos.wiki/wiki/VSCodium to document this. I guess we could create a pkgs.vscodium-with-extensions that already has that set as the default.

@stale
Copy link

stale bot commented Jul 1, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 1, 2020
@turion
Copy link
Contributor Author

turion commented Jul 14, 2020

I want to try this at some point soon

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 14, 2020
@stale
Copy link

stale bot commented Jan 11, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 11, 2021
@panda2134
Copy link
Contributor

As nix refuses to install vscode-with-extensions by default due to licensing issues, creating vscodium-with-extensions actually makes sense (due to its MIT license).

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 28, 2022
@tv42
Copy link

tv42 commented Jan 21, 2024

I'm using a pretty strict allowUnfreePredicate that does not include vscode, and vscode-with-extensions.override { vscode = vscodium; } works just fine for me, without complaints about non-free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants