Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox failing to build due to rustc update #73023

Closed
jonringer opened this issue Nov 8, 2019 · 8 comments
Closed

Firefox failing to build due to rustc update #73023

jonringer opened this issue Nov 8, 2019 · 8 comments

Comments

@jonringer
Copy link
Contributor

Firefox is faililng to build due to log limit being exceeded.

see: https://hydra.nixos.org/build/105989750/nixlog/1

cc @worldofpeace @taku0

@taku0
Copy link
Contributor

taku0 commented Nov 8, 2019

The last words in the log:
https://hydra.nixos.org/build/105989490/nixlog/1/raw

error[E0204]: the trait `Copy` may not be implemented for this type
  --> /build/firefox-70.0.1/obj-x86_64-pc-linux-gnu/x86_64-unknown-linux-gnu/release/build/style-c564edf60d55a972/out/gecko/structs.rs:23:287610
   |
23 | # [ allow ( non_snake_case , non_camel_case_types , non_upper_case_globals ) ] ...

Maybe this commit affects the problem.

commit 14ee26ccf5cf5f1d320a0a5d249a6b6ae3f2b105
Author: Eelco Dolstra <edolstra@gmail.com>
Date:   Thu Nov 7 15:04:06 2019 +0100

    rustc: 1.38.0 -> 1.39.0

@jonringer
Copy link
Contributor Author

very likely, also broke rustbindgen

@taku0
Copy link
Contributor

taku0 commented Nov 8, 2019

Made PR #73039 for rustc.

@vcunat vcunat changed the title Firefox failing to build on hydra due to log limit exceeded Firefox failing to build due to rustc update Nov 8, 2019
@oscarvarto
Copy link
Contributor

Firefox keeps failing to build even after #73039

@taku0 taku0 mentioned this issue Nov 8, 2019
10 tasks
@taku0
Copy link
Contributor

taku0 commented Nov 8, 2019

firefox package is not updated yet. Made PR #73050.

@worldofpeace
Copy link
Contributor

worldofpeace commented Nov 8, 2019

@edolstra Shouldn't we be updating rustc on staging and not master?

@taku0
Copy link
Contributor

taku0 commented Nov 9, 2019

#73050 is merged. @jonringer could you check build and close if succeeds?

@jonringer
Copy link
Contributor Author

launches fine, thank you all ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants