Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networking.wireless nixos module name leads to confusion #73942

Open
adisbladis opened this issue Nov 22, 2019 · 5 comments
Open

networking.wireless nixos module name leads to confusion #73942

adisbladis opened this issue Nov 22, 2019 · 5 comments
Assignees
Labels
0.kind: bug 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos

Comments

@adisbladis
Copy link
Member

adisbladis commented Nov 22, 2019

Describe the bug
networking.wireless makes it sound like you need it enabled for wifi, this is not the case and most wifi users probably want networking.networkmanager instead.

I propose we rename this option set to networking.wpa_supplicant (while providing an alias for backwards) compat, and change all the documentation to reflect the new naming.

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module: networking.wireless networking.networkmanager

cc @jtojnar @flokli @symphorien @worldofpeace @peterhoeg @dtzWill

@worldofpeace
Copy link
Contributor

I think I can speak for the maybe 15 people I've encountered that had no idea what software networking.wireless was. If it were a custom nixos interface working with everything wireless in existence, maybe it could be so abstract. But you can clearly identify here it's just wpa_supplicant, and I've also thought it should just be named as such. It's just as identifiable as network-manager and the last thing you want is someone to be confused/misconstrued on which network setup they have. Especially if you're switching to NixOS.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 22, 2019

I propose we rename this option set to networking.wpa_supplicant

The problem is we already have networking.supplicant, to complicate things further. See #22401

In my opinion we should really rewrite the whole module to be backend independent, though it's a lot of work.

@flokli
Copy link
Contributor

flokli commented Nov 25, 2019

We spoke about that during the NixOS networkd meetup aswell (notes still pending to be uploaded to discourse), but yes, this is really unintuitive, and should be moved to services.(wpa_)supplicant .

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@flokli
Copy link
Contributor

flokli commented Jun 1, 2020

I think a good first start would be to rename this to services.wpa_supplicant (and not yet be backend independent). Any takers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos
Projects
None yet
Development

No branches or pull requests

6 participants