Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt needs update to 5.14 and more maintainers #74355

Closed
jpathy opened this issue Nov 27, 2019 · 14 comments · Fixed by #84232
Closed

Qt needs update to 5.14 and more maintainers #74355

jpathy opened this issue Nov 27, 2019 · 14 comments · Fixed by #84232

Comments

@jpathy
Copy link
Contributor

jpathy commented Nov 27, 2019

qt 5.13 has been released for a while now.

@nrdxp
Copy link
Contributor

nrdxp commented Jan 1, 2020

indeed 5.14 is also out now. I would be glad to help package a newer version. It appears we may need to expand in the insufficient readme.

dtzWill/nixpkgs@f43e098, it appears patches were generated for qtbase with no documentation explaining how those patches were generated or how to remake them for new versions. Did you use a script? Considering sharing your thought process.

@ttuegel, The patched modules appear to be out of date. Are you still hosting the patched qt5 modules? I only checked out your fork of qtbase, but the version was only up to 5.9 leaving me curious how we got patches generated for newer versions?

@ttuegel
Copy link
Member

ttuegel commented Jan 16, 2020

I only checked out your fork of qtbase, but the version was only up to 5.9 leaving me curious how we got patches generated for newer versions?

If the patches didn't need significant changes between versions (which is pretty likely) then the contributor who updated Nixpkgs probably didn't open a pull request to my forked modules.

The problem here is that Qt 5.13 made significant changes to the build system. It will require a large effort to update the packages, possibly as much as packaging Qt in the first place. Unfortunately, I do not expect I will ever have time to sit down and figure this out myself, so the packages have stagnated.

@nrdxp
Copy link
Contributor

nrdxp commented Feb 2, 2020

So essentially this is gonna get really out of date, really quickly if someone doesn't repackage everything from scratch. Should we perhaps raise the severity of this issue to raise awareness before it gets too bad?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 4, 2020

@worldofpeace Can you make this a priority for 20.03/pin this issue?

@worldofpeace
Copy link
Contributor

@worldofpeace Can you make this a priority for 20.03/pin this issue?

We totally need to help out @ttuegel here, but as nothing is (apparently) severely broken, and we're soo close to beta, I can't see someone contributing this until 20.09.
But if you have reasons to disagree please share them.

As stated at

The problem here is that Qt 5.13 made significant changes to the build system. It will require a large effort to update the packages, possibly as much as packaging Qt in the first place. Unfortunately, I do not expect I will ever have time to sit down and figure this out myself, so the packages have stagnated.

@ttuegel mentioned they'd never have the time figure that out themselves and it seems fairly difficult.
I do agree this is of high severity and needs the communities attention 👍

@worldofpeace worldofpeace added this to the 20.09 milestone Feb 4, 2020
@worldofpeace worldofpeace changed the title qt 5.13.x Qt needs update to 5.14 and more maintainers Feb 4, 2020
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 4, 2020

we're soo close to beta, I can't see someone contributing this until 20.09.

Yeah, I've just realized the feature freeze is next week. It makes sense to target the next release.

@ttuegel
Copy link
Member

ttuegel commented Feb 6, 2020

I can't see someone contributing this until 20.09.

I know this isn't ideal, but Qt 5.12 is the current LTS version and has a longer support window than Qt 5.13 or Qt 5.14, so releasing NixOS 20.03 with Qt 5.12 isn't all bad.

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/please-fix-all-packages-which-were-broken-by-the-qt-wrapping-changes/6444/16

@ghost
Copy link

ghost commented Apr 3, 2020

Related: qutebrowser/qutebrowser#5329

@ghost ghost self-assigned this Apr 4, 2020
@ghost
Copy link

ghost commented Apr 4, 2020

I rebased the qtbase patchset as best as I could without having a clue about the Qt build system, and so far it seems to be surprisingly successful. I will report back on how the builds turned out tomorrow.

@ghost
Copy link

ghost commented Apr 4, 2020

Okay so I could not really believe it at first but this seems to have worked:

screenshot

TLSv1.3 is working fine now and also clipboard support on wayland is much better.

@ghost ghost mentioned this issue Apr 4, 2020
37 tasks
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/get-openboard-working-under-nixos/7293/3

@deliciouslytyped
Copy link
Contributor

deliciouslytyped commented Jun 14, 2020

There are some regressions in qt5.14 that prevent some applications from running except with 5.13 (or at least they have avoided upgrading till now), so it would be good if they both end up in the package set.

@gebner
Copy link
Member

gebner commented Aug 22, 2020

We are now at Qt 5.14, I think we can close this.

Feel free to reopen and retitle "needs to update to 5.15".

@gebner gebner closed this as completed Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants