Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OfBorg down #83929

Closed
jonringer opened this issue Apr 1, 2020 · 5 comments · Fixed by #83933
Closed

OfBorg down #83929

jonringer opened this issue Apr 1, 2020 · 5 comments · Fixed by #83933

Comments

@jonringer
Copy link
Contributor

Fails to begin evaluation

example failure : https://gist.github.com/GrahamcOfBorg/d7255f6d266d54b9332df592dfb595a1

example PR (if still relevant): #83922
cc @grahamc

@offlinehacker
Copy link
Contributor

There seems to be also an error in nixpkgs, where building nixos results in infinite recursion, but it seems to be independent of this issues, as error persists, even if i rebase on nixos-unstable branch??

[xtruder@redacted:~/projects/nixpkgs]$ ((75a164ef4c1...)) nix-build nixos/tests/memcached.nix
error: infinite recursion encountered, at /home/xtruder/projects/nixpkgs/lib/modules.nix:552:14
(use '--show-trace' to show detailed location information)

@jonringer
Copy link
Contributor Author

offending commit: f8a78af

cc @worldofpeace

@jonringer
Copy link
Contributor Author

this seems to concur with the --show-trace

while evaluating definitions from `/home/jon/projects/nixpkgs/nixos/modules/security/systemd-confinement.nix':
while evaluating 'dischargeProperties' at /home/jon/projects/nixpkgs/lib/modules.nix:467:25, called from /home/jon/projects/nixpkgs/lib/modules.nix:396:137:
while evaluating the attribute 'value' at /home/jon/projects/nixpkgs/lib/modules.nix:281:44:
while evaluating 'mapAttrsToList' at /home/jon/projects/nixpkgs/lib/attrsets.nix:233:23, called from /home/jon/projects/nixpkgs/nixos/modules/security/systemd-confinement.nix:147:40:
while evaluating the attribute 'systemd.services' at undefined position:
while evaluating anonymous function at /home/jon/projects/nixpkgs/lib/modules.nix:84:45, called from undefined position:
while evaluating the attribute 'value' at /home/jon/projects/nixpkgs/lib/modules.nix:383:9:
while evaluating the option `systemd.services':
while evaluating the attribute 'mergedValue' at /home/jon/projects/nixpkgs/lib/modules.nix:415:5:
while evaluating the attribute 'values' at /home/jon/projects/nixpkgs/lib/modules.nix:409:9:
while evaluating the attribute 'values' at /home/jon/projects/nixpkgs/lib/modules.nix:508:7:
while evaluating anonymous function at /home/jon/projects/nixpkgs/lib/modules.nix:395:28, called from /home/jon/projects/nixpkgs/lib/modules.nix:395:17:
while evaluating definitions from `/home/jon/projects/nixpkgs/nixos/modules/services/desktops/geoclue2.nix':
while evaluating 'dischargeProperties' at /home/jon/projects/nixpkgs/lib/modules.nix:467:25, called from /home/jon/projects/nixpkgs/lib/modules.nix:396:137:
while evaluating the attribute 'condition' at /home/jon/projects/nixpkgs/lib/modules.nix:552:14:
while evaluating the attribute 'condition' at /home/jon/projects/nixpkgs/lib/modules.nix:552:14:
while evaluating the attribute 'condition' at /home/jon/projects/nixpkgs/lib/modules.nix:552:14:
while evaluating the attribute 'enable' at undefined position:
while evaluating anonymous function at /home/jon/projects/nixpkgs/lib/modules.nix:84:45, called from undefined position:
while evaluating the attribute 'value' at /home/jon/projects/nixpkgs/lib/modules.nix:383:9:
while evaluating the option `services.geoclue2.enable':
while evaluating the attribute 'mergedValue' at /home/jon/projects/nixpkgs/lib/modules.nix:415:5:
while evaluating the attribute 'values' at /home/jon/projects/nixpkgs/lib/modules.nix:409:9:
while evaluating the attribute 'values' at /home/jon/projects/nixpkgs/lib/modules.nix:508:7:
while evaluating anonymous function at /home/jon/projects/nixpkgs/lib/modules.nix:395:28, called from /home/jon/projects/nixpkgs/lib/modules.nix:395:17:
while evaluating definitions from `/home/jon/projects/nixpkgs/nixos/modules/config/locale.nix':
while evaluating 'dischargeProperties' at /home/jon/projects/nixpkgs/lib/modules.nix:467:25, called from /home/jon/projects/nixpkgs/lib/modules.nix:396:137:
while evaluating the attribute 'condition' at /home/jon/projects/nixpkgs/lib/modules.nix:552:14:
while evaluating the attribute 'provider' at undefined position:
while evaluating anonymous function at /home/jon/projects/nixpkgs/lib/modules.nix:84:45, called from undefined position:
while evaluating the attribute 'value' at /home/jon/projects/nixpkgs/lib/modules.nix:383:9:
while evaluating the option `location.provider':
while evaluating the attribute 'mergedValue' at /home/jon/projects/nixpkgs/lib/modules.nix:415:5:
while evaluating the attribute 'values' at /home/jon/projects/nixpkgs/lib/modules.nix:409:9:
while evaluating the attribute 'values' at /home/jon/projects/nixpkgs/lib/modules.nix:508:7:
while evaluating anonymous function at /home/jon/projects/nixpkgs/lib/modules.nix:395:28, called from /home/jon/projects/nixpkgs/lib/modules.nix:395:17:
while evaluating definitions from `/home/jon/projects/nixpkgs/nixos/modules/services/desktops/geoclue2.nix':
while evaluating 'dischargeProperties' at /home/jon/projects/nixpkgs/lib/modules.nix:467:25, called from /home/jon/projects/nixpkgs/lib/modules.nix:396:137:
while evaluating the attribute 'condition' at /home/jon/projects/nixpkgs/lib/modules.nix:552:14:
while evaluating the attribute 'condition' at /home/jon/projects/nixpkgs/lib/modules.nix:552:14:
while evaluating the attribute 'condition' at /home/jon/projects/nixpkgs/lib/modules.nix:552:14:
infinite recursion encountered, at /home/jon/projects/nixpkgs/lib/modules.nix:552:14

@jonringer
Copy link
Contributor Author

actually, the other offending line is in locale.nix:

    services.geoclue2.enable = mkIf (lcfg.provider == "geoclue2") true;

I think that's setting to enable, which then causes the geoclue2 to reset the provider to geoclue, which then causes infinite recursion.

@jonringer
Copy link
Contributor Author

Seems like the main issue is that we have 2 ways of declaring that geoclue2 should be used:

  • services.geoclue2.enable
  • location.provider

I think the correct course of action would be to eliminate one of these options. Seeing as location.provider is stringly typed, and only used to set services.geoclue2.enable = true;, I think it can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants