Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct electron package wrapGAppsHook usage #84913

Closed
worldofpeace opened this issue Apr 10, 2020 · 1 comment · Fixed by #84981
Closed

Correct electron package wrapGAppsHook usage #84913

worldofpeace opened this issue Apr 10, 2020 · 1 comment · Fixed by #84981

Comments

@worldofpeace
Copy link
Contributor

Describe the bug
The electron package tries to wrap in buildCommand.
Because of this the wrapper is completely void of any entries in XDG_DATA_DIRS.
It needs to be rewritten in whatever fashion that the makeWrapper call happens in postFixup.

This is why riot-desktop has needed to be wrapped recently fe6addb, it's because electron isn't wrapped correctly itself. A change should be made to stable to revert this to riot-desktop, and to backport this fix instead.

Expression: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/electron/generic.nix#L59

buildInputs should also have glib for it's setup-hook https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/electron/generic.nix#L37.

@prusnak
Copy link
Member

prusnak commented Apr 11, 2020

I created a PR here: #84981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants