Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evil regex in pkgs/build-support/fetchurl/write-mirror-list.sh #8561

Closed
gitfoxi opened this issue Jun 29, 2015 · 4 comments
Closed

Evil regex in pkgs/build-support/fetchurl/write-mirror-list.sh #8561

gitfoxi opened this issue Jun 29, 2015 · 4 comments

Comments

@gitfoxi
Copy link

gitfoxi commented Jun 29, 2015

This line breaks my bootstrap on alpine linux:

grep '^[a-zA-Z]\+=.*://' > $out

This works. Tested on alpine and ubutnu:

egrep '^[a-zA-Z]+=.*://' > $out
@Profpatsch
Copy link
Member

(triage) Needs severety:mass-rebuild.

Is it save to assume egrep?

@jpierre03
Copy link
Contributor

(triage) @gitfoxi @Profpatsch @edolstra
cc @domenkozar @globin
Original file : https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/fetchurl/write-mirror-list.sh
This file is unchanged since 2008.

PR #21861 created with @gitfoxi idea or maybe this issue can be closed ?

@vcunat vcunat closed this as completed in a652099 Jan 13, 2017
@vcunat
Copy link
Member

vcunat commented Jan 13, 2017

Note: it doesn't rebuild anything, thanks to fetchurl producing fix-output derivations.

@jpierre03
Copy link
Contributor

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants