Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libguestfs-with-appliance does a build while it can wrap #86633

Open
wmertens opened this issue May 3, 2020 · 4 comments
Open

libguestfs-with-appliance does a build while it can wrap #86633

wmertens opened this issue May 3, 2020 · 4 comments
Labels
0.kind: bug 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

Comments

@wmertens
Copy link
Contributor

wmertens commented May 3, 2020

Describe the bug

libguestfs has a separate libguestfs-appliance as well as a libguestfs-with-appliance attribute. The first one is built by Hydra and the second one is trivial; the third one does a full build.

Instead, why not make libguestfs-with-appliance be something like

#!/bin/sh
export LIBGUESTFS_PATH=${libguestfs-appliance}
${libguestfs}/bin/guestmount "$@"

no rebuild needed.

This works for me in my tiny test but I don't know about further implications, I only use libguestfs for this one guestmount command.

Thoughts @volth ?

@emilazy
Copy link
Member

emilazy commented May 3, 2020

Members of the maintainers group can assign labels/close issues/etc. now.

@stale
Copy link

stale bot commented Oct 30, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Development

No branches or pull requests

3 participants
@wmertens @emilazy and others