Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the kernels merge_config.sh instead of generate-config.pl #88073

Open
deliciouslytyped opened this issue May 18, 2020 · 4 comments
Open

Use the kernels merge_config.sh instead of generate-config.pl #88073

deliciouslytyped opened this issue May 18, 2020 · 4 comments
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: kernel

Comments

@deliciouslytyped
Copy link
Contributor

deliciouslytyped commented May 18, 2020

Per information I've been given, we should probably be using https://github.com/torvalds/linux/blob/60bef52c7a68257048f34ce32b8300def71a3de0/scripts/kconfig/merge_config.sh to merge our extra kernel configuration options into the kernel configuration, instead of whatever we do in generate-config.pl.

Is there any reason this was avoided or is it coincidental?
cc @teto @infinisil @edolstra

I'm told generate-config is naive and it's an existing problem that dependencies of settings will not be enabled when you enable a setting, leading to somewhat obscure errors mostly of the form:

Error in reading or end of file.

when configuring the kernel, in the linux-config derivation.

Edit:
I wouldn't call it naive, I am sure that these problems can be fixed with the script. The actual issue is the dependency handling, so that should be fixed. Whether it is done by changing the script for fixing the current one doesn't matter.

@deliciouslytyped
Copy link
Contributor Author

Eelco has observed generate-config appears to predate merge_config.sh.

@stale
Copy link

stale bot commented Nov 14, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 14, 2020
@lovesegfault
Copy link
Member

Not stale, getting rid of generate-config.pl would make enabling LTO'd kernels easier.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 11, 2021
@lovesegfault
Copy link
Member

I'm working on this during OceanSprint and it's highly nontrivial, the issue being that merge_config.sh doesn't support the autoModules thing we use, which happens to be load-bearing.

Without autoModules nothing works and work is needed to refactor commonConfig to also enable all the dependencies for what it needs.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: kernel
Projects
None yet
Development

No branches or pull requests

3 participants