tor-browser-bundle-bin: Some website tabs crash reproducibly

[schmittlauch]

Describe the bug

When trying to open some web pages in tor-browser-bundle-bin, the tab reproducibly crashes after load.
This issue does not appear in the Windows build or when running the Linux64 build under Ubuntu, so this bug appears to be related to the Nix packaging.
It also isn't related to a broken browser profile, as deleting ~/.local/share/tor-browser does not resolve the issue.

Link to upstream bug: https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33186

To Reproduce
Steps to reproduce the behavior:

1. nix-shell -p tor-browser-bundle-bin --run tor-browser
2. Try opening one of the websites https://facebookcorewwwi.onion/ http://planet.blogsport.de/
3. See the tab crash after loading has finished

Screenshots

Additional context
tor-browser-bundle-bin-9.5.3 from nixpkgs 20.03.2790.b4dac6714d7

Notify maintainers

@offlinehacker @matejc @doublec @thoughtpolice @joachifm @hax404 @scaredmushroom ( @andir for firefox knowledge)

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute: tor-browser-bundle-bin
# a list of nixos modules affected by the problem
module:

[marius851000]

this issue doesn't happen for tor-browser-bundle-bin-9.5.3 NixOS, 20.09.20200805.6a0fd33 , but I was able to reproduce it with your version.

[marius851000]

Found this was solved with the commit 45e2ff3
It explicitly say:

    * tor-browser: disable hardening by default
    
    this seems to cause crashes with certain tabs.
    relevant issue: https://github.com/NixOS/nixpkgs/issues/86356
    
    * Update pkgs/applications/networking/browsers/tor-browser-bundle-bin/default.nix
    
    Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>

[marius851000]

backported here: #95688

[stale]

I marked this as stale due to inactivity. → More info

[schmittlauch]

fixed by #95688.