Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services. nginx.enableSandbox still exists #97611

Closed
aanderse opened this issue Sep 10, 2020 · 0 comments · Fixed by #97631
Closed

services. nginx.enableSandbox still exists #97611

aanderse opened this issue Sep 10, 2020 · 0 comments · Fixed by #97631
Labels
0.kind: bug 6.topic: nixos 9.needs: clean-up

Comments

@aanderse
Copy link
Member

ping @Izorkin @Mic92 @Ma27 @flokli

It was agreed that services.nginx.enableSandbox should be removed before 20.09. It was generally accepted that an enableSandbox option isn't a great idea and was added to the module temporarily for ease of testing. It is important to remove this because other people have seen this option and started believing this is an accepted design pattern for NixOS modules - we don't want people getting the wrong idea and having more options like this slip in.

@Izorkin can you please file a PR removing this option and the entry from the 20.09 release notes?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug 6.topic: nixos 9.needs: clean-up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nixos/nginx: remove option enableSandbox Izorkin/nixpkgs
2 participants
@veprbl @aanderse