nixos/modules/system/boot/luksroot.nix: Should I remove preLVM ?

[hugolgst]

Hello,

I saw this comment and was wondering if I could make a PR to remove this option.

nixpkgs/nixos/modules/system/boot/luksroot.nix

Line 583 in 18348c7

# FIXME: get rid of this option.

[stale]

I marked this as stale due to inactivity. → More info

[aexoxea]

Noting this is marked as stale, but...

I use this option (as do others, cf. #33565), and would prefer it not be removed until there is a solution that will allow LUKS-on-LVM setups to work without setting boot.initrd.luks.devices.<name>.preLVM = false;. Removing it without such a solution (and ideally an upgrade path) will leave users with such setups either unable to boot or unable to upgrade.

(Of course, if you just want to remove the comment itself, I'd be fine with that 😄!)

[hugolgst]

Do you know why this comment was added?

[aexoxea]

No I don't sorry -- the line was added at 8103971, a large merge from 5 years ago, and there's no detail I can see as to why.

[Artturin]

git blame --ignore-rev 96f5788346ae nixos/modules/system/boot/luksroot.nix

845c9b5

[hugolgst]

I guess we can therefore remove the comment.

[stale]

I marked this as stale due to inactivity. → More info