(nixos/calibre-server): Add new http & auth options #216497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelreyrol
force-pushed
the
calibre-server-options
branch
from
eead884
to
c335a74
Compare
gaelreyrol
force-pushed
the
calibre-server-options
branch
from
c335a74
to
a303d60
Compare
gaelreyrol
force-pushed
the
calibre-server-options
branch
from
e9abdd4
to
83ad549
Compare
gaelreyrol
force-pushed
the
calibre-server-options
branch
from
83ad549
to
740a975
Compare
gaelreyrol
force-pushed
the
calibre-server-options
branch
from
740a975
to
1056196
Compare
gaelreyrol
force-pushed
the
calibre-server-options
branch
2 times, most recently
from
0dffbc1
to
899ac1a
Compare
|
@GrahamcOfBorg test calibre-server |
gaelreyrol
force-pushed
the
calibre-server-options
branch
from
899ac1a
to
9dd2f60
Compare
drupol
approved these changes
Jun 28, 2023
gaelreyrol
force-pushed
the
calibre-server-options
branch
from
9dd2f60
to
5cc6fea
Compare
gaelreyrol
force-pushed
the
calibre-server-options
branch
from
5cc6fea
to
37def1a
Compare
drupol
approved these changes
Jun 28, 2023
drupol
requested changes
Jun 28, 2023
gaelreyrol
force-pushed
the
calibre-server-options
branch
2 times, most recently
from
22a753b
to
f129289
Compare
|
@GrahamcOfBorg test calibre-server |
nixos/doc: add calibre-server new options
gaelreyrol
force-pushed
the
calibre-server-options
branch
from
f129289
to
caa3c0f
Compare
drupol
approved these changes
Jun 28, 2023
| serviceConfig = { | ||
| User = cfg.user; | ||
| Restart = "always"; | ||
| ExecStart = "${cfg.package}/bin/calibre-server ${lib.concatStringsSep " " cfg.libraries} ${execFlags}"; |
There was a problem hiding this comment.
I don't know if the /bin/calibre-server is required
There was a problem hiding this comment.
The package calibre contains multiple executables and calibre-server is not the default one.
There was a problem hiding this comment.
Fair enough. If needed, the meta attribute mainProgram can be set in the derivation so it's not needed here.
|
@GrahamcOfBorg test calibre-server |
drupol
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
It is my first contribution to the nixpkgs repository and I hope my changes are not that bad!
This PR adds 4 new options to the
calibre-serverservice. It will allow to configure host interface & port and auth configuration.I also add a test for a simple custom case.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)