termineter: init at 1.0.4 #277125
Open
termineter: init at 1.0.4 #277125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WolfangAukang
suggested changes
Dec 27, 2023
t4ccer
force-pushed
the
t4/termineter
branch
from
b2e5909
to
d244472
Compare
|
I've changed python sources to github, didn't realize that there is a difference and fetching from pypi won't fetch tests, thanks for catching that |
|
Result of 10 packages built:
|
WolfangAukang
approved these changes
Dec 27, 2023
|
Result of 10 packages built:
|
quantenzitrone
approved these changes
Dec 28, 2023
fabaff
reviewed
Dec 31, 2023
t4ccer
force-pushed
the
t4/termineter
branch
from
d244472
to
51b0812
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3721 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added termineter package and a couple of python dependencies
Tracked in #81418
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.