Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernelshark: 2.2.1 -> 2.3.1 #290920

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Conversation

Emantor
Copy link
Member

@Emantor Emantor commented Feb 23, 2024

Description of changes

Bump the package and move it over to qt6.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@IogaMaster IogaMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review has been done with warden, please report any issues!

Packages built

✅ kernelshark

nix-info -m

  • system: "x86_64-linux"
  • host os: Linux 6.1.77, NixOS, 24.05 (Uakari), 24.05.20240216.5863c27
  • multi-user?: yes
  • sandbox: relaxed
  • version: nix-env (Nix) 2.19.3
  • nixpkgs: /etc/nix/inputs/nixpkgs

pkgs/os-specific/linux/trace-cmd/kernelshark.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/trace-cmd/kernelshark.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/trace-cmd/kernelshark.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/trace-cmd/kernelshark.nix Outdated Show resolved Hide resolved
@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 290920 run on x86_64-linux 1

1 package built:
  • kernelshark

@Emantor Emantor changed the title kernelshark: 2.2.1 -> 2.3.0 kernelshark: 2.2.1 -> 2.3.1 May 26, 2024
@Emantor Emantor requested a review from Scrumplex May 26, 2024 11:40
Bump the package and move it over to qt6.
@Emantor
Copy link
Member Author

Emantor commented May 26, 2024

Thanks for the thorough review @Scrumplex 👍

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 290920 run on x86_64-linux 1

1 package built:
  • kernelshark

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1697

@SuperSandro2000 SuperSandro2000 merged commit 0e8ee5e into NixOS:master Jun 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants