Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basalt-monado: init at release-673cc5c6 #295107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

basalt-monado: init at release-673cc5c6 #295107

wants to merge 1 commit into from

Conversation

loco-choco
Copy link
Member

@loco-choco loco-choco commented Mar 11, 2024 •
edited

Description of changes

Basalt for Monado "is a fork of Basalt improved for tracking XR devices with Monado."
Adds the package in #294764 for #245005 (comment).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@loco-choco
Copy link
Member Author

For testing the executables, try the example on Usage on the Basalt for Monado repository.

@loco-choco loco-choco force-pushed the basalt-monado-init branch 3 times, most recently from ea1377b to 912b51a Compare March 11, 2024 21:17
@loco-choco loco-choco changed the title basalt-monado: init at main-2024-02-12 basalt-monado: init at release-673cc5c6 Mar 11, 2024
@loco-choco loco-choco requested a review from drupol March 12, 2024 00:07
Scrumplex
Scrumplex reviewed Apr 12, 2024
View reviewed changes
pkgs/by-name/ba/basalt-monado/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ba/basalt-monado/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ba/basalt-monado/package.nix Outdated Show resolved Hide resolved
@Scrumplex
Copy link
Member

Also, this doesn't build when rebased onto master, because tbb_2021_8 doesn't exist anymore: #301391

@loco-choco loco-choco force-pushed the basalt-monado-init branch 2 times, most recently from 3628d71 to d488a19 Compare April 13, 2024 01:12
@loco-choco
Copy link
Member Author

Also, this doesn't build when rebased onto master, because tbb_2021_8 doesn't exist anymore: #301391

Updating to tbb_2021_11 seems fine, so I will just change it to that.

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 295107 run on x86_64-linux 1

1 package built:
  • basalt-monado

Scrumplex
Scrumplex approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derivation looks good to me. Haven't had an opportunity to test this though

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-try-a-package-from-a-pr-thats-not-yet-merged/44137/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3834

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 295107 run on x86_64-linux 1

1 package built:
  • basalt-monado

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

@drupol drupol Awaiting requested review from drupol

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer needs_reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@loco-choco @Scrumplex @nixos-discourse @wegank