pgmanage: fix build #36164
Merged
pgmanage: fix build #36164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@GrahamcOfBorg test pgmanage |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
There is a similar problem for pgadmin3. Does it makes sense I spent some time fixing this (for |
|
@lsix yes, I don't think it will be changed back. |
Mic92
reviewed
Mar 1, 2018
| @@ -11,6 +11,10 @@ stdenv.mkDerivation rec { | |||
| sha256 = "0g9kvhs9b6kc1s7j90fqv71amiy9v0w5p906yfvl0j7pf3ayq35a"; | |||
| }; | |||
|
|
|||
| patchPhase = '' | |||
| sed -e "s~#!/bin/sh~#!$SHELL ~" -i src/configure | |||
There was a problem hiding this comment.
I did not know of patch Shebangs, I’ll look into it. Based on its name, it should do exactly what I expect it to do.
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
The configure script uses the `command` builtin command which is bash specific while having a "#!/bin/sh" head. This forces the use nix default shell (bash)
|
@Mic92 I just fixed it. |
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
@GrahamcOfBorg test pgmanage |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Recent backport of postgresql to 17.09 broke few things, including pgmanage (https://hydra.nixos.org/eval/1437029). While I do not see why this is related, this fixes pgmanage. I’ll check later how this is affecting master.
The configure script uses the
commandbuiltin command which is bashspecific[1] while having a "#!/bin/sh" head.
This forces the use nix default shell (bash)
[1] https://www.gnu.org/software/bash/manual/html_node/Bash-Builtins.html#Bash-Builtins
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)