Skip to content

Commit

Permalink
add new eval checker for the package list with allowAliases = false
Browse files Browse the repository at this point in the history
closes #248

By checking the package list without aliases, we can make it more
likely that people do not introduce new aliases into `nixpkgs` without
removing them from the repository. Aliases are supposed to be for
backward compatibility.

Also, we can make sure this configuration option continues to work for
people. Noteably, this configuration option is used by
r-ryantm/nixpkgs-update to avoid submitting duplicate pull requests
for the package and its alias, and to use the correct (non-alaised)
name in the pull request.
  • Loading branch information
ryantm committed Oct 14, 2018
1 parent 6a07411 commit cd47393
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions ofborg/src/tasks/massrebuilder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,19 @@ impl<E: stats::SysEvents + 'static> worker::SimpleWorker for MassRebuildWorker<E
self.nix.clone()
),

EvalChecker::new(
"package-list-no-aliases",
nix::Operation::QueryPackagesJSON,
vec![
String::from("--file"),
String::from("."),
String::from("--arg"),
String::from("config"),
String::from("{ allowAliases = false; }"),
],
self.nix.clone()
),

EvalChecker::new(
"nixos-options",
nix::Operation::Instantiate,
Expand Down

0 comments on commit cd47393

Please sign in to comment.