Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use less obscure arrow symbols in performance report #360

Closed
Synthetica9 opened this issue May 8, 2019 · 2 comments · Fixed by #362
Closed

Use less obscure arrow symbols in performance report #360

Synthetica9 opened this issue May 8, 2019 · 2 comments · Fixed by #362

Comments

@Synthetica9
Copy link
Member

Synthetica9 commented May 8, 2019 •
edited

The issue, as seen on my machine

Currently, the 🡖 character (U+1F856, "South East Sans-Serif Arrow") is used in performance reports. This character doesn't seem to be very widely supported by fonts yet, as it was only introduced in 2014, with Unicode 7.0.

I propose changing this to the ↘ (U+2198, "South East Arrow"), which has much wider support, since it has been in the standard since 1993, with Unicode 1.1.

This has the effect of rendering the character as an emoji on some platforms, which doesn't seem like a huge downside, possibly an upside.
@grahamc
Copy link
Member

grahamc commented May 8, 2019

I'd love to merge a PR improving this. Mind sending one?

Synthetica9 added a commit to Synthetica9/ofborg that referenced this issue May 8, 2019
@Synthetica9
Use more widely supported arrow symbol in performance report
8a52ef5 
Fixes NixOS#360.
@Synthetica9
Copy link
Member Author

@grahamc See #362

Synthetica9 added a commit to Synthetica9/ofborg that referenced this issue May 8, 2019
@Synthetica9
Use more widely supported arrow symbol in performance report
8a41517 
Fixes NixOS#360.
@Synthetica9 Synthetica9 mentioned this issue May 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use more widely supported arrow symbol in performance report Synthetica9/ofborg
2 participants
@grahamc @Synthetica9