New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable trusted users for now #564
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
approved these changes
May 17, 2021
grahamc
reviewed
May 17, 2021
cole-h
force-pushed
the
disable-trusted-users
branch
from
May 17, 2021 20:17
32c4e17
to
1bc578e
Compare
grahamc
approved these changes
May 17, 2021
The current darwwin builder is reset very, very frequently (mostly due to its storage constraints necessitating it), so there's much less of a reason to limit the people who can utilize it. (Enabling it for everybody will also guarantee more frequent resets, as well.) However, it is kept as an option so that it can be re-enabled some time in the future, if anything were to happen.
cole-h
force-pushed
the
disable-trusted-users
branch
from
May 17, 2021 20:21
1bc578e
to
452ee25
Compare
This is perhaps a bit controversial. The only acronym that I allowed is the NixOS acronym all the others are required to follow the clippy naming conventions.
grahamc
approved these changes
May 17, 2021
This was referenced May 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current darwwin builder is reset very, very frequently (mostly due to its
storage constraints necessitating it), so there's much less of a reason to limit
the people who can utilize it. (Enabling it for everybody will also guarantee
more frequent resets, as well.)
However, it is kept as an option so that it can be re-enabled some time in the
future, if anything were to happen.
Closes #559.