Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label PRs with "bsd" in the title #573

Merged
merged 4 commits into from
Mar 16, 2022
Merged

Label PRs with "bsd" in the title #573

merged 4 commits into from
Mar 16, 2022

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Aug 2, 2021

I haven't tested this beyond cargo test, because I don't really know how.

@r-burns
Copy link

r-burns commented Oct 23, 2021

Should we try to do something clever with word splitting so it doesn't match on e.g. "libsdl"?

@alyssais
Copy link
Member Author

That would be better for sure, but exceeds the amount of energy I can put into this, since it would be changing quite a lot how this code works.

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to get this in in its current form (once my singular nit is addressed), even with the potential for false-positive labels. As unlikely as it is now, if somebody added a project by the name of darwini or sigmacosine, those would also be falsely tagged. As long as you're fine with the potential for noise in this label, this can be addressed later (when I or another interested party has time).

ofborg/src/tasks/eval/nixpkgs.rs Outdated Show resolved Hide resolved
alyssais and others added 3 commits March 15, 2022 18:33
This will make it easier to add new topic labels.
This prevents a PR named "libsdl: xyz" being tagged as "6.topic: bsd".

This is slightly more robust than simply checking if the strings
"bsd" or "darwin" or "macos" are present in the title.
@cole-h
Copy link
Member

cole-h commented Mar 16, 2022

I've let this grow long in the tooth, and I'm sorry about that.

I just pushed a commit that uses the regex crate so that we can match on word boundaries using the \b anchor. This is slightly more robust than just checking for the existence of the string "bsd" or "macos" or "darwin" in the title. (regex was already in our dependency tree, so it's almost free using it :)

I hope to merge this sometime soon (but for real this time).

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants