-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label PRs with "bsd" in the title #573
Conversation
Should we try to do something clever with word splitting so it doesn't match on e.g. "libsdl"? |
That would be better for sure, but exceeds the amount of energy I can put into this, since it would be changing quite a lot how this code works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to get this in in its current form (once my singular nit is addressed), even with the potential for false-positive labels. As unlikely as it is now, if somebody added a project by the name of darwini
or sigmacosine
, those would also be falsely tagged. As long as you're fine with the potential for noise in this label, this can be addressed later (when I or another interested party has time).
This will make it easier to add new topic labels.
This prevents a PR named "libsdl: xyz" being tagged as "6.topic: bsd". This is slightly more robust than simply checking if the strings "bsd" or "darwin" or "macos" are present in the title.
I've let this grow long in the tooth, and I'm sorry about that. I just pushed a commit that uses the I hope to merge this sometime soon (but for real this time). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again :)
I haven't tested this beyond
cargo test
, because I don't really know how.