Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval/nixpkgs: parse more commit messages #642

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

rhendric
Copy link
Member

@rhendric rhendric commented Jun 7, 2023

Add support for expanding the Bash-like brace syntax and for removing bracketed prefixes like [Backport ...] [that was stupid; those are found in the PR titles, not the commit messages].

Add support for expanding the Bash-like brace syntax.
@rhendric rhendric force-pushed the rhendric/parse-commit-messages branch from c3b9f3a to 8bf5316 Compare June 7, 2023 04:35
Copy link
Member

@Artturin Artturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

library seems simple enough and the tests pass

README.md Outdated Show resolved Hide resolved
Co-authored-by: Artturi <Artturin@artturin.com>
@asymmetric
Copy link

I would suggest making an announcement on Discourse if this gets merged, otherwise people might miss it.

@cole-h
Copy link
Member

cole-h commented Sep 15, 2023

I just pushed a small commit (6af23b6) that adds a note why the format! call is necessary.

I'll merge and deploy this later today (just to make sure that my previous deploy of #650 works as I expect).

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(To expand on my hand-wavey "later today", here's an explicit time:) I expect I'll merge and deploy this around 11AM Pacific (in roughly 4 hours).

@cole-h cole-h merged commit de415d3 into NixOS:released Sep 15, 2023
2 checks passed
@rhendric rhendric deleted the rhendric/parse-commit-messages branch September 16, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants