Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC 0139] Declarative filesystem layouts #139

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

l0b0
Copy link

@l0b0 l0b0 commented Jan 11, 2023

WIP, feel free to get involved.

@Lassulus @Mic92 As the biggest contributors to Disko, your ideas & contributions would be very welcome. I feel like declarative filesystem layouts could massively simplify one of the biggest, riskiest, and most long-standing complexities of installing any Linux distro.

@Lassulus
Copy link
Member

I will try to chime in when I find some time, but if you want to do a jitsi session or something like that I could talk a bit about plans to integrate disko into nixpkgs. maybe one can sketch out the RFC after that :)

@AndersonTorres
Copy link
Member

The idea of this is to use the Nix language to describe the hard disk layout?

@l0b0
Copy link
Author

l0b0 commented Jan 29, 2023

The idea of this is to use the Nix language to describe the hard disk layout?

Yes, ideally in such a way as to make sure the info can be used to both apply the structure (using any of the standard tools, like fdisk) and to declare them at runtime in for example /etc/fstab.

@samueldr
Copy link
Member

One thing to consider in your write-up: what happens when the end-user changes the described layout on a running system?

In the past, non-commital lightweight discussions about that topic always ended-up at that dead-end, where declaratively describing this inherently stateful thing can't be handled through the lifecycle of NixOS systems, except at the very start before the first generation is booted, otherwise known as "installation".

Again, something to consider, please continue :).

@Lassulus
Copy link
Member

Well we can't really change the filesystem of the system we are running on without losing a bunch of files. But maybe we can add a flag (similiar to how we handle the bootloader) to try to force the application of the filesystem changes. We could then kexec into a live system. rescue some files we care about, reformat the disks and then bootup into the new system. with a lot of files lost though

@maljub01
Copy link

maljub01 commented Jan 30, 2023

A recent MacOS update forced filesystem changes on all devices (including removing /nix). This was done by adding a "Relocated Items" folder on the user's desktop and placing all the files there that would otherwise be deleted/lost. I remember thinking that this was a pretty neat solution. A similar idea is the lost+found directories used in some Linux filesystems. Maybe we can do something similar?

Maybe this could work:

  1. Copy the files that would be deleted/lost to a path in the Nix Store.
  2. Have a /nix/lost+found directory.
  3. Add a garbage collection root to the Nix Store path from step 1 above under /nix/lost+found.

EDIT: Actually, it's probably a bad idea to use the lost+found name in case /nix is using its own filesystem that adds that directory itself. But there are plenty of other names that can be used.

@claes
Copy link

claes commented Mar 10, 2023

Could Ignition serve as an example?
https://coreos.github.io/ignition/examples/

@arianvp
Copy link
Member

arianvp commented May 23, 2023

Note that we recently merged repart support which allows you to declaratively create your partitions and filesystems. Adding support for it to nixes-install is definitely something I'd like

NixOS/nixpkgs#232533

@l0b0
Copy link
Author

l0b0 commented May 24, 2023

Note that we recently merged repart support which allows you to declaratively create your partitions and filesystems. Adding support for it to nixes-install is definitely something I'd like

Excellent!

@nikstur Thank you! Especially like the test. Is this going to be in 23.05? Is there a PR with documentation on the way? And is it possible to use this to bootstrap a NixOS install?

@nyabinary
Copy link

Any status on this?

@l0b0
Copy link
Author

l0b0 commented Nov 23, 2023

@nyabinary There's been a lot of excellent feedback, and it sounds like people would be interested in the feature, but I don't feel qualified to lead this to completion by myself. As far as I'm concerned, there are a few possible next steps. Off the top of my head and in no particular order:

  • Evaluate systemd-repart as a partial or complete solution to this. I'm not familiar with it, I haven't seen any examples of it, and I don't know whether it's appropriate for this use case.
  • Evaluate the Ignition syntax as an alternative to Disko. I'm not familiar with either, but it looks like they could both do the job. On the other hand, we need to be wary of analysis paralysis and bikeshedding.
  • Come up with common use cases (like initial setup when booting from USB/network, how to change an existing system, etc) and solutions. For example, maybe nixos-rebuild needs a new flag or subcommand to apply the configuration, or to check whether the configuration needs applying.
  • Have a big get-together to work out what people are most interested in/worried by.
  • Work out what would be a minimal first step towards this and implement that rather than designing a bunch up front.

@nyabinary
Copy link

Any status on this?

I feel like this plus impermanence would be great, but impermanence would def be out of scope for this RFC.

@nyabinary
Copy link

I can help/be the new author of this for now if nobody else steps up, I still think this is a great idea.

@Mic92
Copy link
Member

Mic92 commented Mar 24, 2024

Disko in the meantime also added support for updating some aspects of the disk configuration in an existing system. Systemd-repart supports some stuff as well but is still more limited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet