[FEAT] Add support for lightning>=2.0.0, and torch>=2.0.0 #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cchallu
approved these changes
Apr 4, 2023
|
@FedericoGarza This could make it difficult to use the library on Google Vertex AI Workbench (the Jupyter notebook of Google Cloud Platform), because the default environment uses Python 3.7 and upgrading the Python version is a bit tricky (although I hope it will be upgraded before Python 3.7 is end-of-life in June). |
|
hey @candalfigomoro! I've tried to support Python 3.7 here but unfortunately, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades lightning and torch to the most recent versions. The main change is
validation_epoch_end -> on_validation_epoch_end(now, the validation outputs need to be stored in thevalidation_stepto be used inon_validation_epoch_end). See this PR.Also, this PR deprecates python3.7 (the minimum version compatible with
lightning>=2.0.0is py3.8).