[FIX] Compute validation loss per epoch #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
kdgutier
approved these changes
Apr 6, 2023
kdgutier
added a commit
that referenced
this pull request
Apr 6, 2023
* feat: add alias argument * fix: mypy hint * tests * HINT Unit Test (#499) * HINT Unit Test * Changed HINT Unit Test to use percent difference * Changed default num_samples from 500 to 1000 While this is a good first step, median hierarchical coherence is not guaranteed by the bootstrap reconciliation method. The unit test needs to be updated in the future for the mean hierarchical coherence. Obtaining the mean outputs however require additional work on various NF components that we will pospone to the future. * [FEAT] Allow pandas 2 (#508) * feat: allow pandas 2 * fix: remove unused cell * Added MS availability to augment_calendar_df function (#506) * feat: compute validation loss per epoch (#507) Co-authored-by: Kin <kin.gtz.olivares@gmail.com> * solving merge conflict --------- Co-authored-by: David Luo <60141418+dluuo@users.noreply.github.com> Co-authored-by: Kin <kin.gtz.olivares@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
self.validation_step_outputsstores the loss of each step and after that, the methodon_validation_epoch_endcomputes the mean amongst them. This PR clearsself.validation_step_outputsafter each epoch to calculate the actual validation loss per epoch. Before this change, the validation loss was calculated using the whole history of losses.