Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Predict dates bug #540

Merged
merged 3 commits into from
Apr 22, 2023
Merged

[FIX] Predict dates bug #540

merged 3 commits into from
Apr 22, 2023

Conversation

cchallu
Copy link
Contributor

@cchallu cchallu commented Apr 22, 2023

  • Fixed a bug on the predict function when dates and uids in df do not match the stored dataset passed during train or cross_validation.
  • Replaced _make_future_df with _future_dates to homologize with other date creating functions.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cchallu cchallu requested a review from AzulGarza April 22, 2023 16:53
Copy link
Member

@AzulGarza AzulGarza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! LGTM :)

@cchallu cchallu merged commit 8948804 into main Apr 22, 2023
8 checks passed
@cchallu cchallu deleted the fix/predict_dates branch April 22, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants